Jerone Young wrote: > So here is another respin .. not so broken for everyone this time ;-) >
Just a few small comments... > ifeq ($(USE_KVM), 1) > LIBOBJS+=qemu-kvm.o > endif > @@ -214,6 +222,7 @@ LIBOBJS+= op_helper.o helper.o > LIBOBJS+= op_helper.o helper.o > ifeq ($(USE_KVM), 1) > LIBOBJS+= qemu-kvm-powerpc.o > +LIBOBJS+= fake-exec.o > endif > endif > Could you move this out of the USE_KVM and PPC checks and simply put it in a ifeq ($(NO_TCG), 1) check? Also, can you move the file into target-ppc? This way, it will be much easier to implement something similar for ia64 and x86. > diff --git a/qemu/fake-exec.c b/qemu/fake-exec.c > new file mode 100644 > --- /dev/null > +++ b/qemu/fake-exec.c > @@ -0,0 +1,62 @@ > Please add a copyright to this file. Regards, Anthony Liguori ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
