On Fri, 15 Feb 2008, Andrew Morton wrote:

> > +#define mmu_rmap_notifier(function, args...)                               
> > \
> > +   do {                                                            \
> > +           struct mmu_rmap_notifier *__mrn;                        \
> > +           struct hlist_node *__n;                                 \
> > +                                                                   \
> > +           rcu_read_lock();                                        \
> > +           hlist_for_each_entry_rcu(__mrn, __n,                    \
> > +                           &mmu_rmap_notifier_list, hlist)         \
> > +                   if (__mrn->ops->function)                       \
> > +                           __mrn->ops->function(__mrn, args);      \
> > +           rcu_read_unlock();                                      \
> > +   } while (0);
> > +
> 
> buggy macro: use locals.

Ok. Same as the non rmap version.

> > +EXPORT_SYMBOL(mmu_rmap_export_page);
> 
> The other patch used EXPORT_SYMBOL_GPL.

Ok will make that consistent.



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to