On Feb 20, 2008, at 9:30 AM, Carlo Marcelo Arenas Belon wrote:
> janitorial fix for :
>
> qemu/qemu-kvm.c: In function `has_work':
> qemu/qemu-kvm.c:140: warning: suggest parentheses around && within ||
>
> Signed-off-by: Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]>
> ---
> qemu/qemu-kvm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
> index ffc59d5..4056453 100644
> --- a/qemu/qemu-kvm.c
> +++ b/qemu/qemu-kvm.c
> @@ -137,7 +137,7 @@ extern int vm_running;
>
> static int has_work(CPUState *env)
> {
> - if (!vm_running || env && vcpu_info[env->cpu_index].stopped)
> + if (!vm_running || (env && vcpu_info[env->cpu_index].stopped))
What exactly is the env check needed for here?
>
> return 0;
> if (!(env->hflags & HF_HALTED_MASK))
It won't be done here anyway...
>
> return 1;
> --
> 1.5.3.7
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
