Christian Borntraeger wrote: > Hello Avi, > > in commit fb56dbb31c4738a3918db81fd24da732ce3b4ae6 you changed > include/linux/Kbuild: > ----snip---- > KVM: Export include/linux/kvm.h only if $ARCH actually supports KVM > Currently, make headers_check barfs due to <asm/kvm.h>, which <linux/kvm.h> > includes, not existing. Rather than add a zillion <asm/kvm.h>s, export > kvm.h only if the arch actually supports it. > [...] > unifdef-y += keyboard.h > -unifdef-y += kvm.h > +unifdef-$(CONFIG_HAVE_KVM) += kvm.h > unifdef-y += llc.h > unifdef-y += loop.h > ----snip------ > > This patch does not work. Kbuild (scripts/Makefile.headersinst) does not > check the config file, so kvm.h is never installed. > > Sam is there an easy way to allow constructs like "unifdef-$(CONFIG_FOO)"? >
I think this cleverness has caused too much trouble already, and adding asm-*/kvm.h would have been better. As I'm about to disappear for a week, consider a patch to remove the config dependency and add asm-*/kvm.h pre-acked for mainline. Maybe the presence of those empty asm-*/kvm.h files will encourage further kvm ports to *. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
