On Thu, Apr 17, 2008 at 12:02 AM, Anthony Liguori <[EMAIL PROTECTED]> wrote: > A couple general comments. > > I'd feel a lot more comfortable with the int13 handler returning an int and > the asm stub code uses that result to determine how to set CF. You set CF > deep within the function stack and there's no guarantee that GCC isn't going > to stomp on it. > > I also don't think we want to raise int18 when we get a command we don't > understand. We should just not change any of the register state. There are > a number of extended commands that look for a magic value to determine > whether the command exists or not.
Absolutely. We should return error code in that case. Thanks, Quynh ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
