Avi Kivity wrote: > Zhang, Xiantao wrote: >> Hi, Avi >> This patch should go into RC1, otherwise it will block kvm/ia64 >> userspace build. >> >> diff --git a/include/asm-ia64/kvm.h b/include/asm-ia64/kvm.h index >> eb2d355..62b5fad 100644 --- a/include/asm-ia64/kvm.h >> +++ b/include/asm-ia64/kvm.h >> @@ -22,7 +22,12 @@ >> */ >> >> #include <asm/types.h> >> + >> +#ifdef __KERNEL__ >> #include <asm/fpu.h> >> +#else >> +#include <signal.h> >> +#endif >> > > Fishy. A kernel header including a userspace header? > > Maybe you need to include <linux/signal.h> unconditionally? Hi, Avi You know, kvm.h is shared by userspace and kernel. But unfortunately, the usersapce header files have redefinition for one strucutre (structure ia64_fpreg) {One in asm/fpu.h and the other one in bits/sigcontext}, maybe a bug here. Therefore, if userspace code includes fpu.h and sigcontext.h in one source file, it will complain the redefinition. Do you have good idea to cope with this issue ? Xiantao
------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel