> -----Original Message-----
> From: Blue Swirl [mailto:blauwir...@gmail.com]
> Sent: Friday, February 27, 2009 2:47 AM
> To: Liu Yu-B13201
> Cc: qemu-de...@nongnu.org; aurel...@aurel32.net;
> holl...@us.ibm.com; kvm-ppc@vger.kernel.org
> Subject: Re: [PATCH 1/5] kvm/powerpc: Enable MPIC for E500 platform.
>
> On 2/26/09, Liu Yu <yu....@freescale.com> wrote:
> > MPIC and OpenPIC have very similar design.
> > So a lot of code can be reused.
> >
> > Modification mainly include:
> > 1. keep struct openpic_t to the maximum size of both MPIC
> and OpenPIC.
> > 2. endianess swap.
> > MPIC has the same endianess as target, so no need to
> swap for MPIC.
> > 3. using different init functions and function pointers
> for reset and irq raise.
> >
> > Haven't test OpenPIC.
> >
> > Signed-off-by: Liu Yu <yu....@freescale.com>
>
> > + struct {
> > + CPUReadMemoryFunc **read;
> > + CPUWriteMemoryFunc **write;
> > + target_phys_addr_t start_addr;
> > + ram_addr_t size;
> > + } list[] = {
> > + {mpic_glb_read, mpic_glb_write,
> MPIC_GLB_REG_START, MPIC_GLB_REG_SIZE},
> > + {mpic_tmr_read, mpic_tmr_write,
> MPIC_TMR_REG_START, MPIC_TMR_REG_SIZE},
> > + {mpic_ext_read, mpic_ext_write,
> MPIC_EXT_REG_START, MPIC_EXT_REG_SIZE},
> > + {mpic_int_read, mpic_int_write,
> MPIC_INT_REG_START, MPIC_INT_REG_SIZE},
> > + {mpic_msg_read, mpic_msg_write,
> MPIC_MSG_REG_START, MPIC_MSG_REG_SIZE},
> > + {mpic_msi_read, mpic_msi_write,
> MPIC_MSI_REG_START, MPIC_MSI_REG_SIZE},
> > + {mpic_cpu_read, mpic_cpu_write,
> MPIC_CPU_REG_START, MPIC_CPU_REG_SIZE},
> > + };
>
> "static const" ?
>
Why static? It's allocated on stack and will be free when function return.
N�����r��y����b�X��ǧv�^�){.n�+����jir)����w* jg��� �����ݢj/���z�ޖ��2�ޙ����&�)ߡ�a���� �G���h��j:+v���w��٥
