On 14.09.2012, at 03:44, Alexander Graf wrote: > > On 14.09.2012, at 03:36, Paul Mackerras wrote: > >> On Fri, Sep 14, 2012 at 02:03:15AM +0200, Alexander Graf wrote: >>> >>> Yup, Considering how different the FPU state on differnet ppc cores is, I'd >>> be more happy with shoving it into something that allows for more dynamic >>> control. Otherwise we'd end up with yet another struct sregs that can >>> contain SPE registers, altivec, and a dozen additions to it :). >>> >>> Please just use one_reg for all of the register synchronization you want to >>> add, unless there's a compelling reason to do it differently. It will make >>> our live a lot easier in the future. If we need to transfer too much data >>> and actually run into performance trouble, we can always add a GET_MANY_REG >>> ioctl. >> >> It just seems perverse to ignore the existing interface that every >> other architecture uses, and instead do something unique that is >> actually slower, but whatever... > > We're slowly moving towards ONE_REG. ARM is already going full steam ahead > and I'd like to have every new register in PPC be modeled with it as well. > The old interface broke on us one time too often now :). > > As I said, if we run into performance problems, we will implement ways to > improve performance. At the end of the day, x86 will be the odd one out.
(plus your patch breaks abi compatibility with old user space) Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
