On 10.04.2013, at 00:37, Paul Mackerras wrote: > On Mon, Apr 08, 2013 at 04:02:13PM +0530, Bharat Bhushan wrote: >> Instruction emulation return EMULATE_DO_PAPR when it requires >> exit to userspace on book3s. Similar return is required >> for booke. EMULATE_DO_PAPR reads out to be confusing so it is >> renamed to EMULATE_EXIT_USER. > > This and the following patch look like an unnecessary and confusing > change to me. If you want an EMULATE_EXIT_USER, why not just add it > and use it in your new code, and leave the EMULATE_DO_PAPR code alone?
I actually suggested that change to Bharat on a former patch review. I think it clutters the EMULATE_ exit ID name space if we extend it with simple "go to user space with message x" types every time we add a new user space exit. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
