> > -static DEFINE_PER_CPU(struct kvm_vcpu *, last_vcpu_on_cpu);
> > +static DEFINE_PER_CPU(struct kvm_vcpu * [KVMPPC_NR_LPIDS],
> last_vcpu_on_cpu);
> 
> Hmm, I didn't know you could express types like that.  Is this special
> syntax that only works for typeof?

Yes, AFAIK.

> No space after *

Checkpatch complains about the missing space ;)

> 
> Name should be adjusted to match, something like last_vcpu_of_lpid (with
> the _on_cpu being implied by the fact that it's PER_CPU).

I was thinking to the long name but it was not appealing, I will change it to
last_vcpu_of_lpid.

-Mike

Reply via email to