On Thu, 2015-06-18 at 16:50 +0100, Andre Przywara wrote: > Currently we set CC unconditionally to ${CROSS_COMPILE}gcc, the same > for LD. > Allow people to override the compiler name by specifying it explicitly > on the command line or via the environment. > Beside calling a certain compiler binary this allows to pass in > options to the compiler, which lets us get rid of the PowerPC > overrides in the Makefile. Possible uses: > $ make CC="gcc -m64" LD="ld -melf64ppc" > (build kvmtool on a PowerPC toolchain defaulting to 32-bit) > $ make CC="gcc -m32" LD="ld -melf_i386" > (build a 32-bit binary on a multilib-enabled x86-64 compiler)
I'm not a big fan of that. Your examples are all about overriding CFLAGS and LDFLAGS, not CC and LD. So if anything you should be allowing that. Adding flags to CC and LD is asking for trouble. cheers -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html