On Wed, May 28, 2008 at 11:25 AM, Paul Brook <[EMAIL PROTECTED]> wrote: > On Wednesday 28 May 2008, Glauber Costa wrote: >> Hi guys, >> >> here's a new spin of the patches I sent yesterday. It basically merges the >> comments I received, and adapts to the current state of the svn tree. >> Also, as Fabrice said multiple times inlining would be better, I'm taking >> a new approach, and instead of defining functions, I'm defining empty >> macros (for the general case), and archictectures that need it can then >> override. It results in substantially less code. > > I'm not so sure this is a good idea. IMHO using macros to implement functions > is ugly. That's what inline functions are for :-) > > Providing a default implementation is also a fairly suspect idea. When adding > a new target I like that we generate an error error when I forget to populate > all of the target specific routines. The same applies when making changes to > generic code, you're forced to go through every target and update them.
ok. If all the rest is fine, I can then switch back to the old model and resend it. > Paul > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act." -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html