On Wed, Oct 1, 2008 at 4:38 AM, Avi Kivity <[EMAIL PROTECTED]> wrote:
> Glauber Costa wrote:
>>
>> Following the pattern we already do, provide a qemu_kvm wrapper to
>> the memory aliases x86 functions. Reason is that we don't want to have
>> references to the context spread over qemu.
>>
>> The destroy alias function is completely removed from libkvm/libkvm.c,
>> since no one in the code base uses it directly.
>>
>> -int kvm_destroy_memory_alias(kvm_context_t kvm, uint64_t phys_start)
>> -{
>> - return kvm_create_memory_alias(kvm, phys_start, 0, 0);
>> -}
>> -
>>
>
> This exists so that readers don't have to wander why you're calling
> kvm_create_memory_alias when you actually want to destroy one.
So what? I'm replacing it with a kvm_qemu_destroy... that does the
very same thing, in the very same way.
only difference is the presence/absence of context.
>
> --
> I have a truly marvellous patch that fixes the bug which this
> signature is too narrow to contain.
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Glauber Costa.
"Free as in Freedom"
http://glommer.net
"The less confident you are, the more serious you have to act."
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
