On Thursday 16 October 2008 16:21:38 Avi Kivity wrote: > Zhang, Xiantao wrote: > > Forget to modify the from item generated automatically by git. Modified > > to Sheng Yang <[EMAIL PROTECTED]> :) > > Xiantao > > > > From c0d1ad6327c01ba0584922022bef48c971bbf18a Mon Sep 17 00:00:00 2001 > > From: Sheng Yang <[EMAIL PROTECTED]> > > Date: Wed, 15 Oct 2008 20:15:06 +0800 > > Subject: [PATCH] KVM: Fix guest shared interrupt with in-kernel irqchip > > > > Every call of kvm_set_irq() should offer an irq_source_id, which is > > allocated by kvm_request_irq_source_id(). Based on irq_source_id, we > > identify the irq source and implement logical OR for shared level > > interrupts. > > > > The allocated irq_source_id can be freed by kvm_free_irq_source_id(). > > > > Currently, we support at most sizeof(unsigned long) different irq > > sources. > > > > > > > > +#define KVM_USERSPACE_IRQ_SOURCE_ID 1 << 0 > > + > > This is dangerous, if used in an expression together with a higher > precedence operator. I fixed it and applied. Thanks to all involved.
Wait a minute.... I think I reserved source id 0 to userspace, rather than 1<<0=1... It's strange... + kvm->arch.irq_sources_bitmap = 1; What really should be addressed is here... I will post a patch to fix it as soon as I saw the commit... -- regards Yang, Sheng -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
