On Monday 27 October 2008 3:29:22 pm Glauber Costa wrote:
> On Mon, Oct 27, 2008 at 6:08 PM, Brian Jackson <[EMAIL PROTECTED]> wrote:
> > When building kvm-userspace from git, gawk and unifdef are used by
> > kernel/Makefile. Without this check it's non-obvious why kernel/Makefile
> > fails.
> >
> > Signed-off-by: Brian Jackson <[EMAIL PROTECTED]>
> >
> > diff --git a/configure b/configure
> > index 3b5d14f..26f73f3 100755
> > --- a/configure
> > +++ b/configure
> > @@ -113,6 +113,17 @@ if [ -d "$kerneldir/include2" ]; then
> > kernelsourcedir=${kerneldir%/*}/source
> > fi
> >
> > +# check for some utils we use
> > +if [ -d .git ] ; then
> > + if [ ! -x "`which gawk`" ] ; then
> > + echo "gawk not installed and necessary for compiling from git"
> > + exit 1
> > + fi
> > + if [ ! -x "`which unifdef`" ] ; then
> > + echo "unifdef not installed and necessary for compiling from
> > git" + exit 1
> > +fi
>
> This is unlikely to be the correct fix. unifdef is provided by the kernel
> tree, under scripts. What we want is something like this:
>
> - unifdef -DCONFIG_$(ARCH_CONFIG) -UCONFIG_$(NONARCH_CONFIG)
> $1.orig > $1; \
> + $(LINUX)/scripts/unifdef -DCONFIG_$(ARCH_CONFIG)
> -UCONFIG_$(NONARCH_CONFIG) $1.orig > $1; \
> [ $$? -le 2 ] && rm $1.orig
>
Huh... I just apt-get installed unifdef and it started working for me, so I
figured that's what it needed.
The other part of the patch should still be good. Avi, want me to resend just
the gawk bit? Or just leave it out and hope people figure out they need gawk.
> > +
> > #configure user dir
> > (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir"
> > \ --arch="$arch" \
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to [EMAIL PROTECTED]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
