On Wed, 2008-11-05 at 22:49 -0600, Hollis Blanchard wrote: > - info->queue = kzalloc(PAGE_ALIGN(vring_size(num,PAGE_SIZE)), > GFP_KERNEL); > + vring_bytes = PAGE_ALIGN(vring_size(num, VRING_PAGE_SIZE)); > + info->queue = kzalloc(vring_bytes, GFP_KERNEL);
You're still aligning the size to PAGE_SIZE rather than VRING_PAGE_SIZE? But actually, why do we align the size anyway? Also might make sense for vring_init() and vring_size() not to take a pagesize argument and hard-code them to use VRING_PAGE_SIZE. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html