On Wednesday 03 December 2008 05:38:21 Hollis Blanchard wrote: > I just spent a number of hours tracking this one down, and I'm not too > thrilled about it. vp_find_vq() does the memory allocation for virtio > PCI rings, and it uses kzalloc() to do it. This is bad because the ring > memory *must* be page-aligned. > > According to Anthony, at the time this code was written, various slab > allocators were checked and all happened to return page-aligned buffers. > So how did I hit a problem? I had enabled CONFIG_SLUB_DEBUG_ON while > investigating an unrelated problem, which offset the address by 64 > bytes. > > One option is to add a BUG_ON(addr & ~PAGE_MASK) to vp_find_vq(). That's > better than nothing, but still stinks.
It's a bug, we fix it. I've complained before, but since there was no evidence of it actually breaking, I didn't push. Prepare a patch, I'll try to get it in this release. Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
