On Tue, 2008-12-16 at 21:38 +0200, Avi Kivity wrote: > The recent qemu merged does not allow net.h to include kvm code (due to > a dependency on cpu.h). This means I had to drop the > kvm_sleep_begin()/kvm_sleep_end() around the packet send (which, btw, > makes the whole thing vulnerable to hotunplug; we need refcounting or > locking here).
How can the tap vlan client be affected by hotunplug? (Dropping the lock from a hotunpluggable PCI device like virtio_net would be dangerous - even though the removal is done by the monitor in the I/O thread and so can't happen while the thread is sleeping, the device isn't actually removed until the guest has acked it with EJ0 and this would be handled by a vcpu thread) Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
