Glauber Costa wrote:


This wasn't introduced by this patch, but the comparison is broken ion i386 hosts, where target_phys_addr_t is 32 bits wide. mem->start_addr + mem->memory_size can overflow (this in fact happens for the bios slot at 4G-128K)
AFAIK, the assumption is that kvm will always be qemu-system-x86_64, due to
migration issues.

That's an incorrect assumption. Users are free to build any qemu variant they like. 32-bit qemu ought to work.

 Then, _target_ phys_addr_t is always 64 bit wide.

It is not. On a 32-bit host, qemu-system-x87_43's target_phys_addr_t is 32 bits wide.

If it's not the case, then this is really a problem.

It isn't, so it is. I hacked around it in kvm-userspace.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to