Paolo Bonzini <pbonz...@redhat.com> writes: > Il 21/04/2014 15:20, Bandan Das ha scritto: >> + for (i = j = 0; i < max_shadow_read_write_fields; i++) { >> + > > Extra empty line. Not a big deal, but... > >> + switch (shadow_read_write_fields[i]) { >> + case GUEST_BNDCFGS: >> + if (!vmx_mpx_supported()) >> + continue; >> + break; >> + default: >> + break; >> + } >> + >> + if (j < i) >> + shadow_read_write_fields[j] = >> + shadow_read_write_fields[i]; >> + j++; > > ... you need to respin anyway because the j++ is wrong. It should be > inside the "if". If you prefer, you can put it in the lhs of the
j++ outside the "if" looks right to me. Can you please explain why you think it shouldn't be that way ? > assignment, otherwise a separate statement is fine by me too. > > Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html