On Fri, May 23, 2014 at 10:28:55PM +0200, Andreas Herrmann wrote: > > > + wmb(); > > > > Wouldn't smp_wmb() be more accurate? > > ... use smp_wmb there ...
A few years ago I reviewed the use of mb()/rmb()/wmb() as opposed to smp_mb()/smp_rmb()/smp_wmb() throughout the kernel. Every single use was a bug should either have been replaced by the smp_* variant because it was not necessary on uniprocessors, was pure cargocult programming or was used for a purpose such I/O where other solutions were required. Ralf -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
