[PATCH v2 5/6] hw_random: don't double-check old_rng.

[Amos Kong]

From: Rusty Russell <ru...@rustcorp.com.au>

Interesting anti-pattern.

Signed-off-by: Rusty Russell <ru...@rustcorp.com.au>
---
 drivers/char/hw_random/core.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 9f6f5bb..6420409 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -473,14 +473,13 @@ int hwrng_register(struct hwrng *rng)
        }
 
        old_rng = current_rng;
+       err = 0;
        if (!old_rng) {
                err = hwrng_init(rng);
                if (err)
                        goto out_unlock;
                set_current_rng(rng);
-       }
-       err = 0;
-       if (!old_rng) {
+
                err = register_miscdev();
                if (err) {
                        drop_current_rng();
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html