Since commit d2a7ddff4 (Add minimal support for macvtap) opening
of tap device might fail. lkvm shows

  Warning: Config tap device error. Are you root?

virtio_net_request_tap passed wrong pointer for struct ifreq to
TUNSETIFF ioctl.

Signed-off-by: Andreas Herrmann <andreas.herrm...@caviumnetworks.com>
---
 virtio/net.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtio/net.c b/virtio/net.c
index d59a0d5..122a9e2 100644
--- a/virtio/net.c
+++ b/virtio/net.c
@@ -287,7 +287,7 @@ static int virtio_net_request_tap(struct net_dev *ndev, 
struct ifreq *ifr,
        if (tapname)
                strncpy(ifr->ifr_name, tapname, sizeof(ifr->ifr_name));
 
-       ret = ioctl(ndev->tap_fd, TUNSETIFF, &ifr);
+       ret = ioctl(ndev->tap_fd, TUNSETIFF, ifr);
 
        if (ret >= 0)
                strncpy(ndev->tap_name, ifr->ifr_name, sizeof(ndev->tap_name));
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to