On 12/11/2015 20:08, Matt Gingell wrote:
> + bool req_int_win = !pic_in_kernel(vcpu->kvm) &&
> vcpu->run->request_interrupt_window;
Hey, this is the new form of dm_request_for_irq_injection I have
just written about, in the review to patch 3.
So it's probably best to swap these two.
> bool req_immediate_exit = false;
>
> + if (irqchip_split(vcpu->kvm))
> + req_int_win = req_int_win && kvm_apic_accept_pic_intr(vcpu);
Overall this is
bool req_int_win =
vcpu->run->request_interrupt_window &&
!pic_in_kernel(vcpu->kvm) &&
(!lapic_in_kernel(vcpu) || kvm_apic_accept_pic_intr(vcpu))
writing it in this form is nice, because it's again very similar to
the tests you're using in patch 3.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
