Re: [PATCH 02/10] KVM: x86: MMU: Add helper function to clear a bit in unsync child bitmap

[Xiao Guangrong]

On 11/12/2015 07:50 PM, Takuya Yoshikawa wrote:

+                       if (!ret) {
+                               clear_unsync_child_bit(sp, i);
+                               continue;
+                       } else if (ret > 0) {
                                nr_unsync_leaf += ret;

Just a single line here, braces are unnecessary.

-                       else
+                       } else
                                return ret;
                } else if (child->unsync) {
                        nr_unsync_leaf++;
                        if (mmu_pages_add(pvec, child, i))
                                return -ENOSPC;
                } else
-                        goto clear_child_bitmap;
-
-               continue;
-
-clear_child_bitmap:
-               __clear_bit(i, sp->unsync_child_bitmap);
-               sp->unsync_children--;
-               WARN_ON((int)sp->unsync_children < 0);
+                       clear_unsync_child_bit(sp, i);
        }

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html