Hi Paolo. On Thu, Dec 17, 2015 at 11:39:14AM +0100, Paolo Bonzini wrote: > > > On 17/12/2015 00:49, James Hogan wrote: > > This patchset contains a bunch of miscellaneous cleanups (which are > > mostly trivial) for MIPS KVM & MIPS headers, such as: > > - Style/whitespace fixes > > - General cleanup and removal of dead code. > > - Moving/refactoring of general MIPS definitions out of arch/mips/kvm/ > > and into arch/mips/include/asm/ so they can be shared with the rest of > > arch/mips. Specifically COP0 register bits, exception codes, cache > > ops, & instruction opcodes. > > - Add MAINTAINERS entry for MIPS KVM. > > > > Due to the interaction with other arch/mips/ code, I think it makes > > sense for these to go via the MIPS tree. > > No objection. > > Acked-by: Paolo Bonzini <pbonz...@redhat.com>
Thanks!
>
> I think I'd use s8/u8 instead of int8_t/uint8_t in patch 15, but really
> that's just me. I'm fine either way, and that's really the only comment
> I have on the series. :)
I'm inclined to agree. u?int(8|16|32)_t all over arch/mips/kvm/ instead
of [us](8|16|32) irritates me as its not very kernel'y.
Ralf: Maybe don't apply patch 15 (I've marked rejected in patchwork),
and I'll do a wider cleanup at some point instead.
Cheers
James
>
> Paolo
>
> > James Hogan (16):
> > MIPS: KVM: Trivial whitespace and style fixes
> > MIPS: KVM: Drop some unused definitions from kvm_host.h
> > MIPS: Move definition of DC bit to mipsregs.h
> > MIPS: KVM: Drop unused kvm_mips_host_tlb_inv_index()
> > MIPS: KVM: Convert EXPORT_SYMBOL to _GPL
> > MIPS: KVM: Refactor added offsetof()s
> > MIPS: KVM: Make kvm_mips_{init,exit}() static
> > MIPS: Move Cause.ExcCode trap codes to mipsregs.h
> > MIPS: Update trap codes
> > MIPS: Use EXCCODE_ constants with set_except_vector()
> > MIPS: Break down cacheops.h definitions
> > MIPS: KVM: Use cacheops.h definitions
> > MIPS: Move KVM specific opcodes into asm/inst.h
> > MIPS: KVM: Add missing newline to kvm_err()
> > MIPS: KVM: Consistent use of uint*_t in MMIO handling
> > MAINTAINERS: Add KVM for MIPS entry
> >
> > MAINTAINERS | 8 +++
> > arch/mips/Kconfig | 3 +-
> > arch/mips/include/asm/cacheops.h | 106 ++++++++++++++++++++--------------
> > arch/mips/include/asm/kvm_host.h | 39 +------------
> > arch/mips/include/asm/mipsregs.h | 34 +++++++++++
> > arch/mips/include/uapi/asm/inst.h | 3 +-
> > arch/mips/kernel/cpu-bugs64.c | 8 +--
> > arch/mips/kernel/traps.c | 52 ++++++++---------
> > arch/mips/kvm/callback.c | 2 +-
> > arch/mips/kvm/dyntrans.c | 10 +---
> > arch/mips/kvm/emulate.c | 118
> > ++++++++++++++++----------------------
> > arch/mips/kvm/interrupt.c | 8 +--
> > arch/mips/kvm/locore.S | 12 ++--
> > arch/mips/kvm/mips.c | 38 ++++++------
> > arch/mips/kvm/opcode.h | 22 -------
> > arch/mips/kvm/tlb.c | 77 +++++++------------------
> > arch/mips/kvm/trap_emul.c | 1 -
> > 17 files changed, 245 insertions(+), 296 deletions(-)
> > delete mode 100644 arch/mips/kvm/opcode.h
> >
> > Cc: Ralf Baechle <r...@linux-mips.org>
> > Cc: Paolo Bonzini <pbonz...@redhat.com>
> > Cc: Gleb Natapov <g...@kernel.org>
> > Cc: linux-m...@linux-mips.org
> > Cc: kvm@vger.kernel.org
> >
signature.asc
Description: Digital signature
