Arnd Bergmann wrote:
On Thursday 14 May 2009, Avi Kivity wrote:
There aren't the real kernel headers, just cheap copies carried in
qemu-kvm.git which have been appropriately postprocessed. We do this
since the kvm external module can run on a much older kernel, so there
is no natural place to find it headers.
Sorry for the confusion on my part. I was aware of the sanitized
kernel headers, but was mislead by the line
kerneldir=/lib/modules/$(uname -r)/build
in kvm/user/configure. What I didn't realize is that this
always gets overridden by kvm/configure.
Maybe we can change the default in kvm/user/configure to
something more sensible:
---
[PATCH] kvm: user: fix default kerneldir
calling ./configure in kvm/user sets the kerneldir to the
currently running kernel, which is incorrect for user code.
This changes the default to the sanitized header files from
the kvm/kernel directory.
Signed-off-by: Arnd Bergmann <a...@arndb.de>
diff --git a/kvm/user/configure b/kvm/user/configure
index efb8705..858a519 100755
--- a/kvm/user/configure
+++ b/kvm/user/configure
@@ -1,7 +1,7 @@
#!/bin/bash
prefix=/usr/local
-kerneldir=/lib/modules/$(uname -r)/build
+kerneldir="$(dirname $0)/../kernel"
cc=gcc
ld=ld
objcopy=objcopy
I usually add a readlink -f in there due to my innate fear of relative
directories and cd.
btw, these are my plans for kvm/user:
- convert the tests to be loadable with qemu -kernel; we lose the
simplicity of kvmctl so I'm not 100% sure it's a good idea. On the
other hand some of the tests are useful for tcg.
- kill kvmtrace (replaced by the standard ftrace tools, whatever they
are; maybe create a new repo if kvm specific tools are needed)
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
