On Tue, Jun 09, 2009 at 02:45:54PM -0300, Glauber Costa wrote: > duplicated save config. > > > diff --git a/hw/virtio.h b/hw/virtio.h > > index 04a3c3d..ce05517 100644 > > --- a/hw/virtio.h > > +++ b/hw/virtio.h > > @@ -72,6 +72,10 @@ typedef struct VirtQueueElement > > > > typedef struct { > > void (*notify)(void * opaque, uint16_t vector); > > + void (*save_config)(void * opaque, QEMUFile *f); > > + void (*save_queue)(void * opaque, int n, QEMUFile *f); > > + int (*load_config)(void * opaque, QEMUFile *f); > > + int (*load_queue)(void * opaque, int n, QEMUFile *f); > > } VirtIOBindings; > > > So, what's the overall effect on a virtual machine that gets migrated, > of a certain device not implementing one of those functions?
Those are implemented by a transport (e.g. virtio_pci) not the device. > Will it work? Will it break? It will work - assuming there's nothing transport-specific you need to save and load. If there is - this patch is not breaking anything that isn't already broken ... -- MST -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html