On Tue, Mar 16, 2010 at 07:22:55PM +0100, Alexander Graf wrote: > > On 16.03.2010, at 17:36, Marcelo Tosatti wrote: > > > On Mon, Mar 15, 2010 at 01:59:52PM +0200, Avi Kivity wrote: > >> Currently when we emulate a locked operation into a shadowed guest page > >> table, we perform a write rather than a true atomic. This is indicated > >> by the "emulating exchange as write" message that shows up in dmesg. > >> > >> In addition, the pte prefetch operation during invlpg suffered from a > >> race. This was fixed by removing the operation. > >> > >> This patchset fixes both issues and reinstates pte prefetch on invlpg. > >> > >> v3: > >> - rebase against next branch (resolves conflicts via hypercall patch) > >> > >> v2: > >> - fix truncated description for patch 1 > >> - add new patch 4, which fixes a bug in patch 5 > > > > Applied, thanks. > > How relevant is this for -stable? Races don't sound good to me :)
The race mentioned above is not existant on -stable since prefetch is disabled for invlpg. The atomic fixes seem like a candidate, since lack of them can trigger pagetable corruption. Avi? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
