Re: [PATCH] KVM: cleanup kvm_get_dirty_log()

[Takuya Yoshikawa]

Xiao Guangrong wrote:

Using bitmap_empty() to see whether memslot->dirty_bitmap is empty

You can do this for arch specific get_dirty_log() too.

Signed-off-by: Xiao Guangrong <xiaoguangr...@cn.fujitsu.com>
---
 virt/kvm/kvm_main.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index bcd08b8..497ae14 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -767,8 +767,7 @@ int kvm_get_dirty_log(struct kvm *kvm,
                        struct kvm_dirty_log *log, int *is_dirty)
 {
        struct kvm_memory_slot *memslot;
-       int r, i;
-       int n;
+       int r, n;
        unsigned long any = 0;

any is no longer need to be unsigned long, if you do this?

r = -EINVAL;

@@ -782,8 +781,7 @@ int kvm_get_dirty_log(struct kvm *kvm,

n = ALIGN(memslot->npages, BITS_PER_LONG) / 8; - for (i = 0; !any && i < n/sizeof(long); ++i)

-               any = memslot->dirty_bitmap[i];
+       any = !bitmap_empty(memslot->dirty_bitmap, memslot->npages);

r = -EFAULT;

        if (copy_to_user(log->dirty_bitmap, memslot->dirty_bitmap, n))

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html