On Wed, May 26, 2010 at 03:36:33PM -0400, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kis...@siemens.com>
> 
> This is obviously a left-over from the the old interface taking the
> size. Apparently a mostly harmless issue with the current iommu_unmap
> implementation.
> 
> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com>

Uh, good catch.

Acked-by: Joerg Roedel <joerg.roe...@amd.com>

> ---
> 
> I think this one is even closer to the right order. :)
> 
>  virt/kvm/iommu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/virt/kvm/iommu.c b/virt/kvm/iommu.c
> index 5adc578..673c88a 100644
> --- a/virt/kvm/iommu.c
> +++ b/virt/kvm/iommu.c
> @@ -273,7 +273,7 @@ static void kvm_iommu_put_pages(struct kvm *kvm,
>               pfn  = phys >> PAGE_SHIFT;
>  
>               /* Unmap address from IO address space */
> -             order       = iommu_unmap(domain, gfn_to_gpa(gfn), PAGE_SIZE);
> +             order       = iommu_unmap(domain, gfn_to_gpa(gfn), 0);
>               unmap_pages = 1ULL << order;
>  
>               /* Unpin all pages we just unmapped to not leak any memory */
> 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to