On Wed, Jul 07, 2010 at 09:11:56PM +0800, Xiao Guangrong wrote: > > > Marcelo Tosatti wrote: > > >> > >> Below codes read gptes in the prefetch path: > >> > >> index = sptep - sp->spt; > >> i = index & ~(PTE_PREFETCH_NUM - 1); > >> max = index | (PTE_PREFETCH_NUM - 1); > >> > >> if (PTTYPE == 32) > >> offset = sp->role.quadrant << PT64_LEVEL_BITS; > >> > >> first_pte_gpa = gfn_to_gpa(sp->gfn) + > >> (offset + i) * sizeof(pt_element_t); > >> > >> if (kvm_read_guest_atomic(vcpu->kvm, first_pte_gpa, gptep, > >> sizeof(gptep)) < 0) > >> return; > >> > >> It reads the 16 aligned items around sptep's corresponding gpte and this > >> gpte > >> is also in this area. :-) > > > > But you removed that in patch 8? > > > > Oh, i just want it good for review, you mean it's better let patch 7 and 8 in > one patch?
I mean patch 7 is wrong because it removes rereading of gpte, with mmu_lock held, in the prefetch patch. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
