On 08/02/2010 08:08 AM, Avi Kivity wrote:
I sent a patch to include the cache size when using -cpu host, but this has been n'acked because the benefit is not clear.


Anthony, why was this NACKed?

I didn't NACK it.

My concern is that we're still not handling live migration with -cpu host in any meaningful way. Exposing more details without addressing live migration is going to increase the likelihood of major failure.

We need to add cpuid information to live migration such that we can generate a graceful failure during migration. Really, we shouldn't have taken -cpu host in the first place without this.

Regards,

Anthony Liguori

First, there are programs which query the cache size. That's why it's exposed! Second, -cpu host is for exposing as many host cpu features as we can, not just those we have an immediate use for. It's like 'cp -a' dropping attributes the author didn't care about.


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to