On 11/30/2010 5:16 PM, Hidetoshi Seto wrote: > Ping. > > Maintainers, please tell me if still something is required for > this patch before applying it.
With Jes's Ack it should be good to go. I will included it in my next pull request to Anthony..and during that time if I see any issues I will let you know. Thanks for working on it. JV. > > > Thanks, > H.Seto > > (2010/11/24 17:01), Jes Sorensen wrote: >> On 11/24/10 03:38, Hidetoshi Seto wrote: >>> This patch introduce a fallback mechanism for old systems that do not >>> support utimensat(). This fix build failure with following warnings: >>> >>> hw/virtio-9p-local.c: In function 'local_utimensat': >>> hw/virtio-9p-local.c:479: warning: implicit declaration of function >>> 'utimensat' >>> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat' >>> >>> and: >>> >>> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod': >>> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this >>> function) >>> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only >>> once >>> hw/virtio-9p.c:1410: error: for each function it appears in.) >>> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this >>> function) >>> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod': >>> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this >>> function) >>> >>> [NOTE: At this time virtio-9p is only user of utimensat(), and is available >>> only when host is linux and CONFIG_VIRTFS is defined. So there are >>> no similar warning for win32. Please provide a wrapper for win32 in >>> oslib-win32.c if new user really requires it.] >>> >>> v5: >>> - Allow fallback on runtime >>> - Move qemu_utimensat() to oslib-posix.c >>> - Rebased on latest qemu.git >>> v4: >>> - Use tv_now.tv_usec >>> v3: >>> - Use better alternative handling for UTIME_NOW/OMIT >>> - Move qemu_utimensat() to cutils.c >>> V2: >>> - Introduce qemu_utimensat() >>> >>> Acked-by: Chris Wright <chr...@sous-sol.org> >>> Acked-by: M. Mohan Kumar <mo...@in.ibm.com> >>> Signed-off-by: Hidetoshi Seto <seto.hideto...@jp.fujitsu.com> >>> --- >>> hw/virtio-9p-local.c | 4 ++-- >>> oslib-posix.c | 48 >>> ++++++++++++++++++++++++++++++++++++++++++++++++ >>> qemu-os-posix.h | 12 ++++++++++++ >>> 3 files changed, 62 insertions(+), 2 deletions(-) >> >> Hi Hidetoshi, >> >> This looks good to me! >> >> Acked-by: Jes Sorensen <jes.soren...@redhat.com> >> >> Cheers, >> Jes > > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
