On 05/09/2011 01:27 PM, Nadav Har'El wrote:
Hi, and thanks again for the reviews.
On Mon, May 09, 2011, Avi Kivity wrote about "Re: [PATCH 17/30] nVMX: Prepare vmcs02
from vmcs01 and vmcs12":
> >+ vmcs_write64(TSC_OFFSET,
> >+ vmx->nested.vmcs01_tsc_offset + vmcs12->tsc_offset);
>
> This is probably wrong (everything with time is probably wrong), but we
> can deal with it (much) later.
I thought this was right :-) Why do you believe it to be wrong?
Just out of principle, everything to do with time is wrong.
L1 wants to add vmcs12->tsc_offset to its own TSC to generate L2's TSC.
But L1's TSC is itself with vmx->nested.vmcs01_tsc_offset from L0's TSC.
So their sum, vmx->nested.vmcs01_tsc_offset + vmcs12->tsc_offset, is the
offset of L2's TSC from L0's TSC. Am I missing something?
Only Zach knows.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
