On Tue, May 17, 2011 at 09:11:32PM +0300, Nadav Har'El wrote: > On Tue, May 17, 2011, Avi Kivity wrote about "Re: [PATCH 08/31] nVMX: Fix > local_vcpus_link handling": > > >VMCSs. If we had only a list of VMCSs, how can we mark the vcpus as being > > >not > > >currently loaded (cpu=-1)? > > > > > > > ->launched and ->cpu simply move into struct vmcs. > > As I explained in the sister thread (this discussion is becoming a tree ;-)) > this is what I planned to do, until it dawned on me that I can't, because > "cpu" > isn't part of vmx (where the vmcs and launched sit in the standard KVM), but > rather part of vcpu... When I gave up trying to "solve" these > interdependencies > and avoiding modifying half of KVM, I came up with the current solution. > > Maybe I'm missing something - I'd be happy if we do find a solution that > simplifies this code.
vcpu->cpu remains there. There is a new ->cpu field on struct vmcs, just as saved_vmcs has in the current patches, to note the cpu which the VMCS was last loaded. As mentioned there is no need to set "vcpu->cpu = -1" in __vcpu_clear, the IPI handler, that can be done in vcpu_clear. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
