On Mon, 2011-06-06 at 15:59 +0200, Alexander Graf wrote:
> Please keep in mind that this is pretty fragile. It will probably work out 
> for you now, but memslots are
> 
>   1) limited

I assume KVM_SET_USER_MEMORY_REGION doesn't fail silenty here?

>   2) don't deal with overlap
> 
> So please add at least a comment here, warning people that this is a
> very simple implementation that could break in subtile ways when
> implementing other hardware that could map its own memory regions
> somewhere else (PCI BARs), but wants them backed by RAM.

Sure - I'll add a comment saying the function doesn't handle overlapping
memory regions.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to