As long as MSI-X is disabled, it's incorrect to invoke msix_handle_mask_update on per-vector mask changes. That may misguide the config notifier callback or spuriously trigger an MSI event.
Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> --- hw/msix.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 176bc76..7d45760 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -292,7 +292,7 @@ static void msix_mmio_write(void *opaque, target_phys_addr_t addr, kvm_msix_update(dev, vector, was_masked, msix_is_masked(dev, vector)); } - if (vector < dev->msix_entries_nr) { + if (msix_enabled(dev) && vector < dev->msix_entries_nr) { is_masked = msix_is_masked(dev, vector); if (was_masked != is_masked) { msix_handle_mask_update(dev, vector); -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html