On 09.12.2011 13:52, Joachim von Buttlar wrote:
Shouldn't it be:               page_set_storage_key(pte_val(*ptep), skey |
_PAGE_CHANGED, 1);

+                                                /* avoid race clobbering 
changed bit
*/
+                                                pte_val(*ptep) |= _PAGE_SWC;
No, the guest GR/GC bits get set to the value userspace wants down
below (this is set storage key after all), and for the host we turn on Martins _PAGE_SWC software bit in the pte to make sure we don't underindicate changed. As far as I can tell, this should be just fine.

Typo:                    /* put acc+f plus guest referenced and changed into the
will fix.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to