On 01/06/2012 07:14 PM, Alexander Graf wrote: > > On 06.01.2012, at 22:12, Scott Wood wrote: > >> On 01/05/2012 08:35 PM, Alexander Graf wrote: >>> Also we're already using KVM_REG for MMIO register identifiers. But I guess >>> we can just reuse the namespace as long as we're careful to not overlap >>> them later. >>> >>> #define KVM_REG_MASK 0x001f >>> #define KVM_REG_EXT_MASK 0xffe0 >>> #define KVM_REG_GPR 0x0000 >>> #define KVM_REG_FPR 0x0020 >>> #define KVM_REG_QPR 0x0040 >>> #define KVM_REG_FQPR 0x0060 >> >> It looks like these are only used internally, despite being in the >> public header -- so renaming these is an option as well if it'd be >> confusing otherwise. > > Yup, let's rename them while we can!
And move them out of the public header -- there's nothing userspace or a guest can sanely do with these. -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
