On 8/27/12 9:53 AM, Andrew Jones wrote:
On Mon, Aug 27, 2012 at 05:51:46PM +0800, Dong Hao wrote:

<snip>

+struct event_stats {
+       u64 count;
+       u64 time;
+
+       /* used to calculate stddev. */
+       double mean;
+       double M2;
+};

How about moving the stats functions from builtin-stat.c to e.g.
util/stats.c, and then reusing them? Then this struct (which I would
rename to kvm_event_stats) would look like this

struct kvm_event_stats {
         u64 time;
         struct stats stats;
};

of course the get_event_ accessor generators would need tweaking

Given the history of the command (first submitted back in February) code refactoring can wait until there is a second user for the stats code.

David
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to