On 10/31/2012 08:20 AM, Sanjay Lal wrote:
Signed-off-by: Sanjay Lal <sanj...@kymasys.com>
---
  arch/mips/kvm/kvm_cb.c        |  16 ++
  arch/mips/kvm/kvm_trap_emul.c | 446 ++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 462 insertions(+)
  create mode 100644 arch/mips/kvm/kvm_cb.c
  create mode 100644 arch/mips/kvm/kvm_trap_emul.c


At a minimum you should probably follow Documentation/CodingStyle

Running checkpatch.pl on all the patches and fixing obvious problems is always a good idea.


diff --git a/arch/mips/kvm/kvm_cb.c b/arch/mips/kvm/kvm_cb.c
new file mode 100644
index 0000000..768198e
--- /dev/null
+++ b/arch/mips/kvm/kvm_cb.c
@@ -0,0 +1,16 @@
+/*
+* This file is subject to the terms and conditions of the GNU General Public
+* License.  See the file "COPYING" in the main directory of this archive
+* for more details.
+*
+* PUT YOUR TITLE AND/OR INFORMATION FOR THE FILE HERE

That line can probably be safely removed.


+*
+* Copyright (C) 2012  MIPS Technologies, Inc.  All rights reserved.
+* Authors: Yann Le Du <l...@kymasys.com>
+*/
.
.
.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to