On Tuesday, December 04, 2012 02:13:11 PM Rusty Russell wrote: > Jason Wang <jasow...@redhat.com> writes: > > On Monday, December 03, 2012 12:25:42 PM Rusty Russell wrote: > >> > + > >> > + /* Work struct for refilling if we run low on memory. */ > >> > + struct delayed_work refill; > >> > >> I can't really see the justificaiton for a refill per queue. Just have > >> one work iterate all the queues if it happens, unless it happens often > >> (in which case, we need to look harder at this anyway). > > > > But during this kind of iteration, we may need enable/disable the napi > > regardless of whether the receive queue has lots to be refilled. This may > > add extra latency. > > Sure, but does it actually happen? We only use the work when we run out > of memory. If this happens in normal behaviour we need to change > something else...
True, I will change to use a global one. Thanks > > Thanks, > Rusty. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
