> > > > Move inside irq_lock protection. > > > > > > > > void kvm_unregister_irq_ack_notifier(struct kvm *kvm, > > > @@ -270,6 +291,7 @@ void kvm_unregister_irq_ack_notifier(struct kvm *kvm, > > > hlist_del_init_rcu(&kian->link); > > > mutex_unlock(&kvm->irq_lock); > > > synchronize_rcu(); > > > + ioapic_update_eoi_exitmap(kvm); > > > > Move both synchronize_rcu and ioapic_update_eoi_exitmap inside irq_lock > > protection. > Why? (here and one above). If vcpu uses stale data during update it will > find recalculate request during guest entry and will recalculate again. > > -- > Gleb.
Indeed, its not necessary and also not necessary to grab irq_lock during vcpu entry, while processing the KVM_REQ_ bit. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
