On Mon, 28 Jan 2013 14:24:25 +0200
Gleb Natapov <g...@redhat.com> wrote:
> On Wed, Jan 23, 2013 at 07:13:21PM +0900, Takuya Yoshikawa wrote:
> > The expression (sp)->gfn should not be expanded using @gfn.
> >
> > Although no user of these macros passes a string other than gfn now,
> > this should be fixed before anyone sees strange errors.
> >
> > Also, the counter-intuitive conditions, which had been used before these
> > macros were introduced to avoid extra indentations, should not be used.
> >
> Not sure what do you mean here. This counter-intuitive conditions are
> used so that if "else" follows the macro it will not be interpreted as
> belonging to the hidden if(). Like in the following code:
>
> if (x)
> for_each_gfn_sp()
> else
> do_y();
>
> You do not expect do_y() to be called for each sp->gfn != gfn.
I could not think of this case.
Will fix not to change the current conditions.
Thanks,
Takuya
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
