On Fri, Aug 09, 2013 at 07:30:13AM -0700, Christoffer Dall wrote: > The KVM_HPAGE_DEFINES are a little artificial on ARM, since the huge > page size is statically defined at compile time and there is only a > single huge page size. > > Now when the main kvm code relying on these defines has been moved to > the x86 specific part of the world, we can get rid of these. > > Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> > --- > > [Resending this because the KVM list filter caught the subject of the > previous message due to the letter X] > > arch/arm/include/asm/kvm_host.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > index 7d22517..e45a74b 100644 > --- a/arch/arm/include/asm/kvm_host.h > +++ b/arch/arm/include/asm/kvm_host.h > @@ -38,11 +38,6 @@ > > #define KVM_VCPU_MAX_FEATURES 1 > > -/* We don't currently support large pages. */ > -#define KVM_HPAGE_GFN_SHIFT(x) 0 > -#define KVM_NR_PAGE_SIZES 1 With huge page support you do have two different page sizes, but the only code that uses those defines currently is in the x86 shadow mmu code, so I am fine with moving gfn_to_index() into x86 specific code and getting rid of those defines (you will probably need them when you will implement nested HYP mode :)). But can you do it as a separate patch series and remove the defines for all arches?
> -#define KVM_PAGES_PER_HPAGE(x) (1UL<<31) > - > #include <kvm/arm_vgic.h> > > struct kvm_vcpu; > -- > 1.7.10.4 > > _______________________________________________ > kvmarm mailing list > kvm...@lists.cs.columbia.edu > https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
