On Mon, Sep 16, 2013 at 09:52:26PM +0800, Xiao Guangrong wrote: > Hi Gleb, > > On 09/16/2013 08:42 PM, Gleb Natapov wrote: > > >> static unsigned long *__gfn_to_rmap(gfn_t gfn, int level, > >> struct kvm_memory_slot *slot) > >> { > >> @@ -4651,7 +4700,7 @@ int kvm_mmu_module_init(void) > >> { > >> pte_list_desc_cache = kmem_cache_create("pte_list_desc", > >> sizeof(struct pte_list_desc), > >> - 0, 0, NULL); > >> + 0, SLAB_DESTROY_BY_RCU, NULL); > > Haven't we agreed that constructor is needed for the cache? > > Yes. I've made it as a separate patch: > [PATCH v2 10/15] KVM: MMU: initialize the pointers in pte_list_desc properly > Ah, I haven't got there yet :)
-- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html