The redistributor TYPER tells the OS about the associated MPIDR,
also the LAST bit is crucial to determine the number of redistributors.

Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
---
Changelog v1 .. v2:
- adapt to new MMIO framework

 virt/kvm/arm/vgic/vgic-mmio-v3.c | 44 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 42 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/arm/vgic/vgic-mmio-v3.c b/virt/kvm/arm/vgic/vgic-mmio-v3.c
index 5f4558c..d137242 100644
--- a/virt/kvm/arm/vgic/vgic-mmio-v3.c
+++ b/virt/kvm/arm/vgic/vgic-mmio-v3.c
@@ -71,6 +71,46 @@ static void vgic_mmio_write_v3_misc(struct kvm_vcpu *vcpu,
 }
 
 /*
+ * We use a compressed version of the MPIDR (all 32 bits in one 32-bit word)
+ * when we store the target MPIDR written by the guest.
+ */
+static u32 compress_mpidr(unsigned long mpidr)
+{
+       u32 ret;
+
+       ret = MPIDR_AFFINITY_LEVEL(mpidr, 0);
+       ret |= MPIDR_AFFINITY_LEVEL(mpidr, 1) << 8;
+       ret |= MPIDR_AFFINITY_LEVEL(mpidr, 2) << 16;
+       ret |= MPIDR_AFFINITY_LEVEL(mpidr, 3) << 24;
+
+       return ret;
+}
+
+static unsigned long vgic_mmio_read_v3r_typer(struct kvm_vcpu *vcpu,
+                                             gpa_t addr, unsigned int len)
+{
+       unsigned long mpidr = kvm_vcpu_get_mpidr_aff(vcpu);
+       int target_vcpu_id = vcpu->vcpu_id;
+       u64 value;
+
+       value = (u64)compress_mpidr(mpidr) << 32;
+       value |= ((target_vcpu_id & 0xffff) << 8);
+       if (target_vcpu_id == atomic_read(&vcpu->kvm->online_vcpus) - 1)
+               value |= GICR_TYPER_LAST;
+
+       return extract_bytes(value, addr & 7, len);
+}
+
+static unsigned long vgic_mmio_read_v3r_iidr(struct kvm_vcpu *vcpu,
+                                            gpa_t addr, unsigned int len)
+{
+       u32 value;
+
+       value = (PRODUCT_ID_KVM << 24) | (IMPLEMENTER_ARM << 0);
+       return extract_bytes(value, addr & 3, len);
+}
+
+/*
  * The GICv3 per-IRQ registers are split to control PPIs and SGIs in the
  * redistributors, while SPIs are covered by registers in the distributor
  * block. Trying to set private IRQs in this block gets ignored.
@@ -127,9 +167,9 @@ static const struct vgic_register_region 
vgic_v3_rdbase_registers[] = {
        REGISTER_DESC_WITH_LENGTH(GICR_CTLR,
                vgic_mmio_read_raz, vgic_mmio_write_wi, 4),
        REGISTER_DESC_WITH_LENGTH(GICR_IIDR,
-               vgic_mmio_read_raz, vgic_mmio_write_wi, 4),
+               vgic_mmio_read_v3r_iidr, vgic_mmio_write_wi, 4),
        REGISTER_DESC_WITH_LENGTH(GICR_TYPER,
-               vgic_mmio_read_raz, vgic_mmio_write_wi, 8),
+               vgic_mmio_read_v3r_typer, vgic_mmio_write_wi, 8),
        REGISTER_DESC_WITH_LENGTH(GICR_PROPBASER,
                vgic_mmio_read_raz, vgic_mmio_write_wi, 8),
        REGISTER_DESC_WITH_LENGTH(GICR_PENDBASER,
-- 
2.7.3

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Reply via email to