Hi,
On 17/01/2017 11:20, Marc Zyngier wrote:
> Rework LPI deallocation so that it can be reused by the v4 support
> code.
>
> Signed-off-by: Marc Zyngier <marc.zyng...@arm.com>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c
> b/drivers/irqchip/irq-gic-v3-its.c
> index dce8f8c..5d96b37 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -865,10 +865,8 @@ static unsigned long *its_lpi_alloc_chunks(int nr_irqs,
> int *base, int *nr_ids)
> return bitmap;
> }
>
> -static void its_lpi_free(struct event_lpi_map *map)
> +static void its_lpi_free_chunks(unsigned long *bitmap, int base, int nr_ids)
> {
> - int base = map->lpi_base;
> - int nr_ids = map->nr_lpis;
> int lpi;
nit: while you are touching the function you may add a blank line after
chunk declaration in the for block
Besides
Reviewed-by: Eric Auger <eric.au...@redhat.com>
>
> spin_lock(&lpi_lock);
> @@ -885,8 +883,7 @@ static void its_lpi_free(struct event_lpi_map *map)
>
> spin_unlock(&lpi_lock);
>
> - kfree(map->lpi_map);
> - kfree(map->col_map);
> + kfree(bitmap);
> }
>
> static struct page *its_allocate_prop_table(gfp_t gfp_flags)
> @@ -1654,7 +1651,10 @@ static void its_irq_domain_free(struct irq_domain
> *domain, unsigned int virq,
> /* If all interrupts have been freed, start mopping the floor */
> if (bitmap_empty(its_dev->event_map.lpi_map,
> its_dev->event_map.nr_lpis)) {
> - its_lpi_free(&its_dev->event_map);
> + its_lpi_free_chunks(its_dev->event_map.lpi_map,
> + its_dev->event_map.lpi_base,
> + its_dev->event_map.nr_lpis);
> + kfree(its_dev->event_map.col_map);
>
> /* Unmap device/itt */
> its_send_mapd(its_dev, 0);
>
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
