On Fri, Feb 23, 2018 at 02:44:30PM +0000, Julien Grall wrote: > Hi Christoffer, > > On 15/02/18 21:03, Christoffer Dall wrote: > >There is really no need to store the vgic_elrsr on the VGIC data > >structures as the only need we have for the elrsr is to figure out if an > >LR is inactive when we save the VGIC state upon returning from the > >guest. We can might as well store this in a temporary local variable. > > > >This also gets rid of the endianness conversion in the VGIC save > >function, which is completely unnecessary and would actually result in > >incorrect functionality on big-endian systems, because we are only using > >typed values here and not converting pointers and reading different > >types here. > > I can't find any endianness code removed in this code. What did I miss? >
Ah, good find, we ended up fixing this in a separate commit: fc396e066318, "KVM: arm/arm64: Fix broken GICH_ELRSR big endian conversion", 2017-12-03 I'll adjust the commit message. Thanks, -Christoffer _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
